43 lines
1.6 KiB
Diff
43 lines
1.6 KiB
Diff
From git@z Thu Jan 1 00:00:00 1970
|
|
Subject: [PATCH v13 31/35] phy: rockchip: usbdp: Drop -EPROBE_DEFER hack
|
|
From: Sebastian Reichel <sebastian.reichel@collabora.com>
|
|
Date: Tue, 14 Jul 2026 21:26:32 +0200
|
|
Message-Id: <20260714-rockchip-usbdp-cleanup-v13-31-6cb3e769d4c5@collabora.com>
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset="utf-8"
|
|
Content-Transfer-Encoding: 7bit
|
|
|
|
The hack to return -EPROBE_DEFER when the lcpll lock timeouts is no
|
|
longer needed. The driver now does a reset during its PHY init, which
|
|
avoids the problem.
|
|
|
|
Since rk_udphy_status_check() is called after the probe, it should not
|
|
return -EPROBE_DEFER.
|
|
|
|
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
|
|
---
|
|
drivers/phy/rockchip/phy-rockchip-usbdp.c | 12 +-----------
|
|
1 file changed, 1 insertion(+), 11 deletions(-)
|
|
|
|
--- a/drivers/phy/rockchip/phy-rockchip-usbdp.c
|
|
+++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c
|
|
@@ -750,17 +750,7 @@ static int rk_udphy_status_check(struct
|
|
(val & CMN_ANA_LCPLL_LOCK_DONE), 200, 100000);
|
|
if (ret) {
|
|
dev_err(udphy->dev, "cmn ana lcpll lock timeout\n");
|
|
- /*
|
|
- * If earlier software (U-Boot) enabled USB once already
|
|
- * the PLL may have problems locking on the first try.
|
|
- * It will be successful on the second try, so for the
|
|
- * time being a -EPROBE_DEFER will solve the issue.
|
|
- *
|
|
- * This requires further investigation to understand the
|
|
- * root cause, especially considering that the driver is
|
|
- * asserting all reset lines at probe time.
|
|
- */
|
|
- return -EPROBE_DEFER;
|
|
+ return ret;
|
|
}
|
|
|
|
if (!udphy->flip) {
|