John AudiaandHauke Mehrtens
bb3da35c90
Changelog: https://cdn.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.12.78 Removed upstreamed: generic/pending-6.12/620-net-sfp-improve-Huawei-MA5671a-fixup.patch[1] generic/pending-6.12/704-net-phy-register-phy-led_triggers-during-probe-to-av.patch[2] airoha/patches-6.12/014-01-v6.13-net-airoha-fix-PSE-memory-configuration-in-airoha_fe.patch[3] airoha/patches-6.12/014-02-v6.13-net-airoha-read-default-PSE-reserved-pages-value-bef.patch[4] airoha/patches-6.12/031-01-v6.13-net-airoha-Read-completion-queue-data-in-airoha_qdma.patch[5] airoha/patches-6.12/128-v7.1-net-airoha-Remove-airoha_dev_stop-in-airoha_remove.patch[6] Manually rebased: airoha/patches-6.12/048-01-v6.15-net-airoha-Move-airoha_eth-driver-in-a-dedicated-fol.patch All patches automatically rebased. 1. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.12.78&id=bbdf6d378e1ddbeadc04c57b182aadefcc3aa917 2. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.12.78&id=241cd64cf2e32b28ead151b1795cd8fef2b6e482 3. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.12.78&id=a04ac7bc97afe313e10ae4c73797c668dee47c5c 4. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.12.78&id=a9ed47c3663219e20406d566f02809de05373a42 5. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.12.78&id=4cba4373abac7ba27fdb33057a29b92efa8fd15d 6. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.12.78&id=652ec118d8dc1b088e685d5562995b6665463771 Signed-off-by: John Audia <therealgraysky@proton.me> Link: https://github.com/openwrt/openwrt/pull/22607 [Fix 048-01-v6.15-net-airoha-Move-airoha_eth-driver-in-a-dedicated-fol] Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
57 lines
2.0 KiB
Diff
57 lines
2.0 KiB
Diff
From 074f4489044e087bbe8a703aed543d154b6574ac Mon Sep 17 00:00:00 2001
|
|
From: Dave Stevenson <dave.stevenson@raspberrypi.org>
|
|
Date: Wed, 13 Jun 2018 15:21:10 +0100
|
|
Subject: [PATCH] net: lan78xx: Disable TCP Segmentation Offload (TSO)
|
|
|
|
TSO seems to be having issues when packets are dropped and the
|
|
remote end uses Selective Acknowledge (SACK) to denote that
|
|
data is missing. The missing data is never resent, so the
|
|
connection eventually stalls.
|
|
|
|
There is a module parameter of enable_tso added to allow
|
|
further debugging without forcing a rebuild of the kernel.
|
|
|
|
https://github.com/raspberrypi/linux/issues/2449
|
|
https://github.com/raspberrypi/linux/issues/2482
|
|
|
|
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
|
|
---
|
|
drivers/net/usb/lan78xx.c | 19 +++++++++++++++++--
|
|
1 file changed, 17 insertions(+), 2 deletions(-)
|
|
|
|
--- a/drivers/net/usb/lan78xx.c
|
|
+++ b/drivers/net/usb/lan78xx.c
|
|
@@ -604,6 +604,15 @@ static int lan78xx_alloc_tx_resources(st
|
|
dev->n_tx_urbs, dev->tx_urb_size, dev);
|
|
}
|
|
|
|
+/* TSO seems to be having some issue with Selective Acknowledge (SACK) that
|
|
+ * results in lost data never being retransmitted.
|
|
+ * Disable it by default now, but adds a module parameter to enable it for
|
|
+ * debug purposes (the full cause is not currently understood).
|
|
+ */
|
|
+static bool enable_tso;
|
|
+module_param(enable_tso, bool, 0644);
|
|
+MODULE_PARM_DESC(enable_tso, "Enables TCP segmentation offload");
|
|
+
|
|
static int lan78xx_read_reg(struct lan78xx_net *dev, u32 index, u32 *data)
|
|
{
|
|
u32 *buf;
|
|
@@ -3466,8 +3475,14 @@ static int lan78xx_bind(struct lan78xx_n
|
|
if (DEFAULT_RX_CSUM_ENABLE)
|
|
dev->net->features |= NETIF_F_RXCSUM;
|
|
|
|
- if (DEFAULT_TSO_CSUM_ENABLE)
|
|
- dev->net->features |= NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_SG;
|
|
+ if (DEFAULT_TSO_CSUM_ENABLE) {
|
|
+ dev->net->features |= NETIF_F_SG;
|
|
+ /* Use module parameter to control TCP segmentation offload as
|
|
+ * it appears to cause issues.
|
|
+ */
|
|
+ if (enable_tso)
|
|
+ dev->net->features |= NETIF_F_TSO | NETIF_F_TSO6;
|
|
+ }
|
|
|
|
if (DEFAULT_VLAN_RX_OFFLOAD)
|
|
dev->net->features |= NETIF_F_HW_VLAN_CTAG_RX;
|