The ACL permissions were originally authored to support just a single
set of modem interfaces, at the numbers 0-9. Eventually this was
adjusted to support from 0 to 999 avoiding command injection.
However, as new commands were added, this was reverted again
unfortunately. Language like "regex" has been used in the commit history
for this ACL, and likely the core of the issue is confusion on how these
are parsed. These are all parsed [1] with fnmatch(...), and not regex(..).
A future useful change could be for rpcd to set the FNM_EXTMATCH option
for fnmatch(...) to simplify this particular match statement, but that's
not considered here since that's a much broader change that needs a
longer discussion.
[1] a4a5a29858/session.c (L143-L147)
Fixes: 54aa70112c ("luci-proto-modemmanager: add status page")
Signed-off-by: Tim Nordell <tnordell@airgain.com>
ModemManager protocol has supported setting initial EPS bearer since
package commit [1], so lets expose the same support via LuCI as well.
[1] af12147f8c
Signed-off-by: Damir Samardzic <damir.samardzic@sartura.hr>
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
This has never worked because the option 'auth' is not known to the
modemmanger proto handler. The correct uci name is 'allowedauth' and is
also a uci list option, so that several options can be selected.
This commit fixes this bug.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Daniel F. Dickinson changed email address to <dfdpublic@wildtechgarden.ca>
luci-all-lxl has a maintainer Petar Koretic <petar.koretic@sartura.hr> but there is no corresponding GitHub account.
So Dirk Brenken was added as a second maintainer: he answered on an issue of the app.
When maintainer wasn't set the initial author was used, or most contributor or Jo-Philipp Wich as a default.
Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
The old term "mobile service" is not common, it is replaced by the new
name "cellular network", which is more familiar.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
If a modem is restarted often, the modem manager object number is
increased by one. Currently, the regex is set so that the modem can no
longer be selected if the object number is greater than 9. This change
fixes that.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
[replace wildcard with rule duplication to disallow option injection]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
This is required to resolve clashes with the generic "option device"
referring to netdev names in current netifd versions.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
The introduction of network device configuration support also implemented
all common, protocol-independent interface options directly in the
interface config view, so drop the redundant option definitions.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
