mirror of
https://github.com/openwrt/luci.git
synced 2026-04-15 19:01:56 +00:00
Firewall.newZone() treated this.getZone(name) (an async function returning a Promise) as if it were synchronous, causing the while loop never to terminate. Although, it's not used anywhere. Sort in getZones was not producing expected results. Now use a localeCompare which returns an integer result for sorting purposes. The previous comparison returned a boolean, but for sorting to work, it must return either -1 to go before, +1 to go after, or 0 for equality. Rule and Redirect shall also have a sid. Signed-off-by: Paul Donald <newtwen+github@gmail.com>