mirror of
https://github.com/openwrt/luci.git
synced 2026-04-15 19:01:56 +00:00
1bf35dff64
As a new person to contributing on GitHub, I noticed the Pull Request template missing some important information that I would not have known until I tried my first Pull Request, such as the character limits and email requirements. I've seen others also get tripped up by this too, as they also were not aware until afterwards. So, I have tried to include the common ones into the template. I have also prepared a layout that would ensure a more uniform experience when looking through Pull Requests, with expected headings and the ability to provide the instruction of what to put under each heading. Minor grammar and punctuation edits as well. If the layout is preferred as a seperate Pull Request, let me know and I will do so. Will also update the CONTRIBUTING.md file to achieve the same goal as well. Signed-off-by: Joshua Criss <owlsy@outlook.com.au>
2.3 KiB
2.3 KiB
Pull Request details
Description
Screenshot or video of changes (If applicable)
Maintainer (Preferred)
@
Tested on
OpenWrt version: LuCI version: Web browser:
Checklist
- This PR is not from my main or master branch 💩, but a separate branch. ✅
- Each commit has a valid ✒️
Signed-off-by: <my@email.address>row (viagit commit --signoff). - Each commit and PR title has a valid 📝
<package name>: titlefirst line subject for packages. - Incremented 🆙 any
PKG_VERSIONin the Makefile. - (Optional) Includes what Issue it closes (e.g. openwrt/luci#issue-number).
- (Optional) Includes what it depends on (e.g. openwrt/packages#pr-number in sister repo).