openwrt/packages
1
0
Fork 0
mirror of https://github.com/openwrt/packages.git synced 2026-05-31 06:51:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

libtheora: disable ARM assembly on pre-ARMv7 targets only

Browse Source 
libtheora's configure probes the host assembler for NEON support
rather than the target CPU, so on pre-ARMv7 (arm926ej-s, etc.) it
falsely succeeds and the build emits NEON the CPU can't execute.
Force --disable-asm only when the ARM target's TARGET_CFLAGS does
not advertise armv7 or armv8, so cortex-a* keeps the NEON path.

Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
This commit is contained in:
Alexandru Ardelean
2026-05-10 12:05:51 +03:00
committed by Alexandru Ardelean
parent a5137522a7
commit 214b265f4a
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libs/libtheora/Makefile
+5 -2
View File
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
PKG_NAME:=libtheora PKG_NAME:=libtheora
PKG_VERSION:=1.2.0 PKG_VERSION:=1.2.0
PKG_RELEASE:=1 PKG_RELEASE:=2
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
PKG_SOURCE_URL:=https://downloads.xiph.org/releases/theora/ PKG_SOURCE_URL:=https://downloads.xiph.org/releases/theora/
PKG_HASH:=ebdf77a8f5c0a8f7a9e42323844fa09502b34eb1d1fece7b5f54da41fe2122ec PKG_HASH:=ebdf77a8f5c0a8f7a9e42323844fa09502b34eb1d1fece7b5f54da41fe2122ec
@@ -49,9 +49,12 @@ CONFIGURE_ARGS += \
--disable-vorbistest \ --disable-vorbistest \
--disable-sdltest --disable-sdltest
ifneq ($(findstring armeb,$(CONFIG_ARCH)),) # --disable-asm on pre-ARMv7 ARM so we don't emit assembler which cannot be executed
ifeq ($(ARCH),arm)
ifeq ($(findstring armv7,$(TARGET_CFLAGS))$(findstring armv8,$(TARGET_CFLAGS)),)
CONFIGURE_ARGS += --disable-asm CONFIGURE_ARGS += --disable-asm
endif endif
endif
define Build/InstallDev define Build/InstallDev
$(INSTALL_DIR) $(1)/usr/include/theora/ $(INSTALL_DIR) $(1)/usr/include/theora/