From a547770f98995c0955a2d2b5199ffc59d79d103a Mon Sep 17 00:00:00 2001 From: Alexandru Ardelean Date: Thu, 9 Apr 2026 09:19:46 +0300 Subject: [PATCH] python3-et_xmlfile: add python3-xml dep, fix test The test.sh imports xml.etree.ElementTree from the stdlib, and et_xmlfile itself falls back to stdlib xml when lxml is unavailable. Add python3-xml to DEPENDS to ensure the xml module is present at both install and test time. The test used et_xmlfile.__version__ without importing the et_xmlfile module (only 'from et_xmlfile import xmlfile' was present). Add 'import et_xmlfile' so the version check works correctly. The test.sh lacked a package name guard, causing it to run (and fail) when the -src subpackage was tested without python3 installed. Add the standard guard to skip the test for non-main packages. Signed-off-by: Alexandru Ardelean --- lang/python/python-et_xmlfile/Makefile | 3 ++- lang/python/python-et_xmlfile/test.sh | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lang/python/python-et_xmlfile/Makefile b/lang/python/python-et_xmlfile/Makefile index bc5457b2dd..db9aab738d 100644 --- a/lang/python/python-et_xmlfile/Makefile +++ b/lang/python/python-et_xmlfile/Makefile @@ -27,7 +27,8 @@ define Package/python3-et_xmlfile URL:=https://bitbucket.org/openpyxl/et_xmlfile DEPENDS:= \ +python3-light \ - +python3-lxml + +python3-lxml \ + +python3-xml endef define Package/python3-et_xmlfile/description diff --git a/lang/python/python-et_xmlfile/test.sh b/lang/python/python-et_xmlfile/test.sh index cb4e5af266..de87c66608 100644 --- a/lang/python/python-et_xmlfile/test.sh +++ b/lang/python/python-et_xmlfile/test.sh @@ -1,5 +1,7 @@ #!/bin/sh +[ "$1" = python3-et_xmlfile ] || exit 0 + EXPECTED_VER="$2" python3 - << EOF @@ -8,6 +10,7 @@ import sys from io import BytesIO from xml.etree.ElementTree import Element +import et_xmlfile from et_xmlfile import xmlfile if (et_xmlfile.__version__ != "$EXPECTED_VER"):