eternalwrt/eternalwrt-mt798x
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

realtek: eth: harden receive path

Browse Source 
The hardware usually takes care that

- a packet is no larger than the available buffer
- has at least a FCS checksum of 4 bytes

Nevertheless be cautious and improve the existing
packet check. Just in case ...

Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/22884
Signed-off-by: Robert Marko <robimarko@gmail.com>
This commit is contained in:
Markus Stockhausen
2026-04-24 09:47:04 +02:00
committed by Robert Marko
parent f56e68791a
commit 3271071579
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
target/linux/realtek/files-6.18/drivers/net/ethernet/rtl838x_eth.c
+3 -3
View File
@@ -1022,11 +1022,11 @@ static int rteth_hw_receive(struct net_device *dev, int ring, int budget)
packet = &ctrl->rx_data[ring].packet[slot];
len = packet->len;
if (!len) {
netdev_err(dev, "empty packet received\n");
if (len < ETH_FCS_LEN || len > RING_BUFFER) {
netdev_err(dev, "invalid packet with %d bytes received\n", len);
break;
} else if (!dsa) {
len -= 4;
len -= ETH_FCS_LEN;
}
skb = netdev_alloc_skb_ip_align(dev, len);