openwrt/luci
1
0
Fork 0
mirror of https://github.com/openwrt/luci.git synced 2026-04-15 19:01:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

luci-app-firewall: fix zone log option

Browse Source 
Changes the zone log checkbox to a multivalue selection as the underlying uci option is a bitfield.

Signed-off-by: Jan Froch <jan@froch.eu>
This commit is contained in:
Jan Froch
2025-02-23 19:39:49 +01:00
committed by Paul Donald
parent cda84c77e3
commit e8a2e458bf
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
applications/luci-app-firewall/htdocs/luci-static/resources/view/firewall/zones.js
View File

@@ -293,11 +293,23 @@ return view.extend({
for (var i = 0; i < ctHelpers.length; i++)
o.value(ctHelpers[i].name, E('<span><span class="hide-close">%s (%s)</span><span class="hide-open">%s</span></span>'.format(ctHelpers[i].description, ctHelpers[i].name.toUpperCase(), ctHelpers[i].name.toUpperCase())));
o = s.taboption('advanced', form.Flag, 'log', _('Enable logging on this zone'));
o = s.taboption('advanced', form.MultiValue, 'log', _('Enable logging'), _('Log matched packets on the selected tables to syslog.'));
o.modalonly = true;
o.value('filter');
o.value('mangle');
o.placeholder = 'No table selected';
const TABLES = { filter: 1, mangle: 2 };
o.cfgvalue = function (section_id) {
let bitfield = this.super('load', [section_id]) || this.default;
return Object.keys(TABLES).filter(table => bitfield & TABLES[table]);
};
o.write = function (section_id, value) {
let bitfield = L.toArray(value).reduce((acc, table) => acc | (TABLES[table] || 0), 0);
return this.super('write', [section_id, bitfield]);
};
o = s.taboption('advanced', form.Value, 'log_limit', _('Limit log messages'));
o.depends('log', '1');
o.depends({log: [], "!reverse": true});
o.placeholder = '10/minute';
o.modalonly = true;