openwrt/luci
1
0
Fork 0
mirror of https://github.com/openwrt/luci.git synced 2026-05-31 10:31:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

luci-base: keep not yet rendered clone elements

Browse Source 
`handleClone` triggers `checkDepends` and also `parse` on `this.map.save` which
in turn also removes not yet rendered elements like clones.

This is not wanted and therefore guarded against.

Signed-off-by: Christian Korber <ckorber@tdt.de>
This commit is contained in:
Christian Korber
2026-05-22 12:00:27 +02:00
committed by Paul Donald
parent 41e3fc3703
commit ec54122a48
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/luci-base/htdocs/luci-static/resources/form.js
+11 -1
View File
@@ -1309,6 +1309,12 @@ const CBIAbstractSection = CBIAbstractElement.extend(/** @lends LuCI.form.Abstra
const sids = this.cfgsections();
for (let i = 0, sid = sids[0]; (sid = sids[i]) != null; i++) {
/*
* do not remove elements that are not rendered yet
*/
if (!this.map.findElement('data-section-id', sid))
continue;
for (let j = 0, o = this.children[0]; (o = this.children[j]) != null; j++) {
let isActive = o.isActive(sid);
const isSatisfied = o.checkDepends(sid);
@@ -2155,7 +2161,11 @@ const CBIAbstractValue = CBIAbstractElement.extend(/** @lends LuCI.form.Abstract
}
}
else if (this.forcewrite || !isEqual(cval, fval)) {
return Promise.resolve(this.write(section_id, fval));
/*
* do not remove elements that are not rendered yet
*/
if (this.map.findElement('data-field', this.cbid(section_id)) != null)
return Promise.resolve(this.write(section_id, fval));
}
}
else if (!this.retain) {