openwrt/packages
1
0
Fork 0
mirror of https://github.com/openwrt/packages.git synced 2026-04-15 10:51:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

php8: revert "php8: fix PHP8_GETTEXT missing icu dependency"

Browse Source 
This reverts commit 996046e642.

After that faulty commit the 'icu' package is always selected
even if php8 itself is not even selected.

Simple bug reproduction process:

 perus@ub2510:/OpenWrt/aarch64$ rm .config
 perus@ub2510:/OpenWrt/aarch64$ touch .config
 perus@ub2510:/OpenWrt/aarch64$ make defconfig
 Collecting package info: done
 ...
 #
 # configuration written to .config
 #

 perus@ub2510:/OpenWrt/aarch64$ grep -iE "php8|icu" .config
 # PHP8
 # CONFIG_PACKAGE_php8 is not set
 CONFIG_PHP8_LIBXML=y
 CONFIG_PHP8_DOM=y
 CONFIG_PHP8_GETTEXT=y
 CONFIG_PHP8_INTL=y
 # CONFIG_PHP8_FULLICUDATA is not set
 # end of PHP8
 CONFIG_PACKAGE_icu=y
 # CONFIG_PACKAGE_icu-data-tools is not set
 # CONFIG_PACKAGE_icu-full-data is not set

Revert the commit, so that a fix can be developed and tested.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
This commit is contained in:
Hannu Nyman
2025-12-31 21:45:30 +02:00
parent 996046e642
commit 7e25efa101
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lang/php8/Makefile
View File

@@ -81,7 +81,6 @@ define Package/php8/config
config PHP8_GETTEXT
bool "Enable gettext"
select PACKAGE_icu
default y
config PHP8_INTL